This repository was archived by the owner on Aug 2, 2021. It is now read-only.
cmd/swarm: new localstore database migration#1297
Merged
nonsense merged 18 commits intolocalstore-storage-integrationfrom Apr 10, 2019
Merged
cmd/swarm: new localstore database migration#1297nonsense merged 18 commits intolocalstore-storage-integrationfrom
nonsense merged 18 commits intolocalstore-storage-integrationfrom
Conversation
acud
force-pushed
the
ls-integration-migration
branch
from
f805f78 to
793e3e6
Compare
Closed
acud
force-pushed
the
ls-integration-migration
branch
3 times, most recently
from
896d485 to
a4df16e
Compare
26 tasks
zelig
suggested changes
Mar 20, 2019
zelig
approved these changes
Mar 22, 2019
cmd/swarm: add ldb fixture for integration testing, add gzip deflate cmd/swarm: pull deflate to helper function cmd/swarm: start swarm with old datastore cmd/swarm: test assert that process exits with non-zero exit code on old db cmd/swarm: assert export size cmd/swarm: remove datadir cmd/swarm: change export verbosity cmd/swarm: fix TestSomething cmd/swarm: rename migration test cmd/swarm: wip e2e test cmd/swarm: wip e2e test swarm: legacy schema detection
…db version on db export too
acud
force-pushed
the
ls-integration-migration
branch
from
4f8cd74 to
8b61fde
Compare
…t, remove unnecessary error log line that might confuse users, simplify legacy db check
Contributor
Author
|
@nonsense I have the results for a dry run migration on my local machine. I'm running an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles and tests the flow of migrating from the old localstore to the new one.
The update sequence is as follows:
swarm db export/chunks)--legacyflagAt a minimum the disk space toll is @
x2andx3at most. We have with @janos decided we do not want to automate this process and we also don't want to add an automatic migration flag to the binary because this will require users to change the way they run Swarm and this change might not be reverted in some cases and can cause trouble in the future (i.e. a User adds a--migrateflag to herrunswarm.shscript and forgets to remove it, cause future migrations to potentially be executed automatically).RTFM: https://hackmd.io/UAV2uybkQlSerVIX5xUF0g?view